ui: add Terminal and Amboss to Lightning explorer options #467
Conversation
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
utACK, definitely nice to have amboss.space as an option, don't have a strong opinion on making it the default though.
jamaljsr
left a comment
jamaljsr
left a comment
There was a problem hiding this comment.
tACK LGTM 👍
Agreed that amboss should certainly be an option.
We are discussing internally what to set the default to as we'd like to also have https://terminal.lightning.engineering/ as an option as well. I'm going to hold off on merging this until that decision is made by the team.
|
Understood! Thanks for checking the PR. As long as we move away from 1ml 😁 |
|
@apotdevin, remember to re-request review from reviewers when ready |
|
Hey @apotdevin we've decided we should add Amboss and Terminal, but make Terminal the default. If you would like to make these changes in the PR, please feel free to. Otherwise, you can close this and I will follow-up with a new PR with the changes. Thanks for sparking the convo to help us get this updated. Appreciate it 👍 |
|
Sounds good! Closing this one then |
|
Reopening this one with the suggested change! |
jamaljsr
left a comment
jamaljsr
left a comment
There was a problem hiding this comment.
tACK LGTM 👍
Apologies for forgetting about this one. Thanks for resurfacing it.
I tested and confirmed it's working as expected. Just needs a small fix then can be merged.
|
No worries! Should have just done the change back then |
jamaljsr
left a comment
jamaljsr
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks again for the update. I just squashed the commits before I merge this.
jamaljsr
changed the title
4 participants
Change to give users a better experience when getting information for other nodes.