Skip to content

github+scripts: check commits compile #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2022
Merged

github+scripts: check commits compile #447

merged 1 commit into from
Nov 3, 2022

Conversation

@ellemouton
Copy link
Member

@ellemouton ellemouton commented Nov 2, 2022 •
edited
Loading

Add a check to github actions to check that each commit in a PR compiles

guggero
guggero approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🎉

bitromortac
bitromortac approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 !

@ellemouton ellemouton merged commit ee664f0 into lightninglabs:master Nov 3, 2022
@ellemouton ellemouton deleted the checkCommits branch November 3, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitromortac bitromortac bitromortac approved these changes

+1 more reviewer

@guggero guggero guggero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ellemouton @guggero @bitromortac