gbn+mailbox: cleanup & prefixed logger

[ellemouton]

This PR introduces a prefixed logger which is then passed to the client and server so that
their logs are prefixed with (client) and (server) so that we dont have to manually use
the isServer variable in logs.

Then, some variables are moved out of the GBN struct and into a new config struct.

depends on #92

[ViktorT-11]

Thanks a lot for this!! This will be really, really helpful 🙏:fire:!!

Left a few comments below, but also leaving one extra feedback here:

Should we change the mailbox/server_conn.go & mailbox/client_conn.go to also use a prefixed logger? Those structs currently have quite a few log calls that adds a separate "Server" & "Client" prefix.

Also, should I change my packeting bug PRs to be based on this already?

[ellemouton]

Thanks @ViktorTigerstrom ! Added the prefixed logger for the mailbox package as you suggested 🙏

[ellemouton]

Also, should I change my packeting bug PRs to be based on this already?

Yeah I think that would be a good idea just so that you get the advantages of the prefixed logger & so that you can take advantage of the slightly cleaner GBN structure.

You can change the base of you PR to gbnCleanup if you want (we must just not forget to change the base of that one before deleting the branch ref after merge)

[ViktorT-11]

tACK LGTM, thanks for this 🙏🔥!!

[guggero]

Very nice! Just a couple of nits, otherwise LGTM 🎉

[ellemouton]

Thanks Y'all 🤓