Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

@ViktorT-11 ViktorT-11 commented Oct 18, 2023

This PR bumps the wasm-client's taproot-assets dependency to v0.3.0-alpha, litd to v0.11.0-alpha & loop to v0.26.4-beta.

The reason why we do this PR before a litd release, is that we'd like to do a litd release that uses an LNC dependency with tapd v0.3.0-alpha, to update the gRPC stubs of tapd to v0.3.0. We'll then do a new litd release, and make one more PR for LNC that updates litd to the new release.

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one request, other than that looks good to me!

@ViktorT-11 ViktorT-11 force-pushed the 2023-10-bump-taproot-assets branch from e746dd7 to 81e6703 Compare October 18, 2023 15:55
Bump taproot-assets to `v0.3.0-alpha`, lightning-terminal to
`v0.11.0-alpha` and loop to `v0.26.4-beta`.
@ViktorT-11 ViktorT-11 force-pushed the 2023-10-bump-taproot-assets branch from 81e6703 to ac61316 Compare October 18, 2023 15:56
@ViktorT-11 ViktorT-11 changed the title wasm-client: bump taproot-assets to v0.3.0-alpha wasm-client & mobile: bump taproot-assets to v0.3.0-alpha Oct 18, 2023
@ViktorT-11 ViktorT-11 changed the title wasm-client & mobile: bump taproot-assets to v0.3.0-alpha wasm-client & mobile: bump taproot-assets to v0.3.0-alpha, litd to v0.11.0-alpha & loop to v0.26.4-beta Oct 18, 2023
@ViktorT-11 ViktorT-11 requested a review from guggero October 18, 2023 15:58
@ViktorT-11
Copy link
Contributor Author

Also updated litd+loop. This PR will now unfortunately clash a bit with @itsrachelfish work, as I know she's working on changes that also does that.

itests failed in the last build, though that was due to a timeout. They're passing this time!

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Tested via make example-server. No issues found.

@guggero guggero merged commit 52192ae into master Oct 18, 2023
@guggero guggero deleted the 2023-10-bump-taproot-assets branch October 18, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants