-
Notifications
You must be signed in to change notification settings - Fork 21
itest: export HashmailHarness struct #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itest: export HashmailHarness struct #76
Conversation
|
looks like we should maybe update the linter config. Linters like |
Ok thanks, was a bit confused about what's happening with the CI! I will look into that @ellemouton! |
66c59d5 to
e801daf
Compare
|
Ok finally got the linter to work properly :)! I updated the config to use a similar config to LND, as I figured it's likely our most up to date linter configs. I pushed the update linter settings as 2 separate commits to this PR. Let me know if you think it's better that I push them as a separate PR instead @ellemouton! |
ellemouton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) one nit :)
951a16a to
66ce69b
Compare
|
Thanks for the review and the feedback @ellemouton! Addressed it with the latest push :) |
|
@bitromortac: review reminder |
bitromortac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍, sorry for the late review
|
Thanks for the review @bitromortac! |
|
@ViktorTigerstrom - the LNC repo prevents me from merging if the commits are not signed (see the "Merging is blocked" warning above) |
Remove deprecated linters and add working setting for previously excluded linters.
66ce69b to
85f5f04
Compare
|
Updated the commits' author to my GPG key email address & signed the commits. |
This PR exports the
HashmailHarnessstruct, so that it can be used as an external dependency to setup a local mail server.