Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

This PR exports the HashmailHarness struct, so that it can be used as an external dependency to setup a local mail server.

@ellemouton
Copy link
Member

looks like we should maybe update the linter config. Linters like exhaustivestruct have been deprecated :)

@ViktorT-11
Copy link
Contributor Author

ViktorT-11 commented May 31, 2023

looks like we should maybe update the linter config. Linters like exhaustivestruct have been deprecated :)

Ok thanks, was a bit confused about what's happening with the CI! I will look into that @ellemouton!

@ViktorT-11 ViktorT-11 force-pushed the 2023-05-export-hashmail-harness branch 5 times, most recently from 66c59d5 to e801daf Compare June 1, 2023 14:27
@ViktorT-11
Copy link
Contributor Author

Ok finally got the linter to work properly :)! I updated the config to use a similar config to LND, as I figured it's likely our most up to date linter configs.

I pushed the update linter settings as 2 separate commits to this PR. Let me know if you think it's better that I push them as a separate PR instead @ellemouton!

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) one nit :)

@ViktorT-11 ViktorT-11 force-pushed the 2023-05-export-hashmail-harness branch 2 times, most recently from 951a16a to 66ce69b Compare June 1, 2023 21:07
@ViktorT-11
Copy link
Contributor Author

Thanks for the review and the feedback @ellemouton! Addressed it with the latest push :)

@ViktorT-11 ViktorT-11 requested a review from bitromortac June 7, 2023 08:04
@lightninglabs-deploy
Copy link

@bitromortac: review reminder

Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, sorry for the late review

@ViktorT-11
Copy link
Contributor Author

Thanks for the review @bitromortac!

@ellemouton
Copy link
Member

@ViktorTigerstrom - the LNC repo prevents me from merging if the commits are not signed (see the "Merging is blocked" warning above)

Remove deprecated linters and add working setting for previously
excluded linters.
@ViktorT-11 ViktorT-11 force-pushed the 2023-05-export-hashmail-harness branch from 66ce69b to 85f5f04 Compare June 14, 2023 09:13
@ViktorT-11
Copy link
Contributor Author

ViktorT-11 commented Jun 14, 2023

Updated the commits' author to my GPG key email address & signed the commits.

@ellemouton ellemouton merged commit a4a8bd6 into lightninglabs:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants