Makefile: fix for iOS library import #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
added a commit
to lightninglabs/lnc-rn
that referenced
this pull request
Nov 22, 2022
Process now automated in lightninglabs/lightning-node-connect#63
guggero
reviewed
Nov 23, 2022
Makefile
Outdated
| mkdir -p $(IOS_BUILD_DIR) | ||
| $(GOMOBILE_BIN) bind -target=ios,iossimulator -tags="mobile $(DEV_TAGS) $(RPC_TAGS)" $(LDFLAGS_MOBILE) -v -o $(IOS_BUILD) $(MOBILE_PKG) | ||
| # modify library files for import without C++ modules | ||
| sed "s|$(IOS_STRING1)|$(IOS_STRING2)|g" $(IOS_FILE1) > $(IOS_FILE1)-temp |
Contributor
There was a problem hiding this comment.
Could use sed -i.bak -E 's|$(IOS_STRING1)|$(IOS_STRING2|g' $(IOS_FILE1) to do the changes inline (with the -i.bak being the version of the flags that seems to work on both MacOS and Linux).
Contributor
Author
There was a problem hiding this comment.
Works like a charm. Updated.
-i by itself was driving me nuts yesterday. Thank you.
kaloudis
force-pushed
the
ios-library-formatting
branch
from
8ecfc13 to
9071d69
Compare
guggero
approved these changes
Nov 29, 2022
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Can't test this as I don't have an Xcode installed but change looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to prevent developers from manually changing their Foundation imports after build LNC mobile for iOS