Skip to content

multi: Bump go to 1.22.3 & litd to v0.13.2-alpha #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2024
Merged

multi: Bump go to 1.22.3 & litd to v0.13.2-alpha #107

merged 3 commits into from
Jul 25, 2024

Conversation

@ViktorT-11
Copy link
Contributor

@ViktorT-11 ViktorT-11 commented Jul 25, 2024

This PR bumps the lightning-terminal dependency in the wasm-client + mobile to v0.13.2-alpha. It also bumps the go version of the lightning-node-connect package to 1.22.3.

@ViktorT-11
Copy link
Contributor Author

ViktorT-11 commented Jul 25, 2024

A question to reviewers: Do you think it's time to upgrade the lnd dependency in the main LNC package? It's currently at v0.16.0. We aren't really using any new features in the main LNC package that needs a later version, but thought it be worth considering either way to not let it be too far behind.

@ViktorT-11 ViktorT-11 requested a review from jamaljsr July 25, 2024 10:05
ellemouton
ellemouton approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

I dont think the lnd bump is needed - looks like it's mainly used for logging etc. Dont think it's an issue to just leave it.

@ViktorT-11
Copy link
Contributor Author

ViktorT-11 commented Jul 25, 2024

Awesome, thanks for the review @ellemouton 🎉🙏!

I dont think the lnd bump is needed - looks like it's mainly used for logging etc. Dont think it's an issue to just leave it.

Ok sounds good!

jamaljsr
jamaljsr approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Tested on regtest and testnet with current and older litd nodes.

@ViktorT-11
Copy link
Contributor Author

ViktorT-11 commented Jul 25, 2024

Awesome, thanks for the review @jamaljsr 🎉🙏!

@ViktorT-11 ViktorT-11 merged commit cb33d4b into lightninglabs:master Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamaljsr jamaljsr jamaljsr approved these changes

@ellemouton ellemouton ellemouton approved these changes

Assignees

@ViktorT-11 ViktorT-11

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViktorT-11 @jamaljsr @ellemouton