Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

This PR makes the logger more informative in debug level for the gbn packet, and also way less verbose as it won't log the current resendTimeout handshakeTimeout when the values are fetched, but instead when they are set.

The logger is also updated to inform when packets are resent even under debug log level.

@ViktorT-11
Copy link
Contributor Author

For testing i recommend first modifying the debug level to debug here:

'--debuglevel=trace',
.
Then make the wasm-client on master vs the new PR with make wasm, followed by the make example-server command and then create a session on the example-site in your browser and inspect the console. You'll then clearly see a difference that the new version is much more informative and less verbose :)!

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero guggero merged commit 08e5d9e into lightninglabs:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants