Skip to content

Conversation

@ellemouton
Copy link
Member

@ellemouton ellemouton commented Jan 5, 2024

Was having some issues running on 1.19 locally so had to make these changes
to get things working and thought I might as well push a PR.

This includes an upgrade to the wasm_exec.js file in order to prevent runtime
errors in a js environment. More info on this can be found here: maxence-charriere/go-app#840.

EDIT: this broke the linter CI check so I also just added a commit to bump the linter version

This includes an upgrade to the wasm_exec.js file in order to prevent
runtime errors in a js environment.
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🎉

@ellemouton
Copy link
Member Author

Thanks @guggero ! pushed 1 more commit just to bump the linter commit

@ellemouton ellemouton requested a review from ViktorT-11 January 5, 2024 09:52
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🎉!

@guggero guggero merged commit 8bc4706 into lightninglabs:master Jan 9, 2024
@ellemouton ellemouton deleted the go-v1.21 branch January 9, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants