Add support for pluggable Authorizer, default to NoopAuthorizer #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G8XSU
force-pushed
the
authorizer
branch
2 times, most recently
from
3d86906 to
07d47d1
Compare
jkczyz
reviewed
Jul 30, 2024
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Just some nits. Otherwise, LGTM.
Different authorizers can act upon headers to return userToken or throw AuthException if auth fails. If hosting providers, want to support alternative auths or add additional checks in auth, they can just implement this interface.
jkczyz
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different authorizers can act upon headers to return userToken or throw AuthException if auth fails.
We can later implement
JWTAuthorizeror others.If hosting providers, want to supply some other variant or add additional checks, they can just implement this interface.
Based on #30.