Don't return ASCII control characters in HTTP error messages #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
May 13, 2021
lightning-block-sync/src/http.rs
Outdated
| let error_details = match String::from(contents) { | ||
| // Check that the string is all-ASCII with no control characters before returning | ||
| // it. | ||
| Ok(s) if s.as_bytes().all(|c| c <= 0x7e && c >= 0x20) => s, |
Contributor
There was a problem hiding this comment.
Could use is_ascii and !is_ascii_control on u8 data before converting.
Collaborator
Author
There was a problem hiding this comment.
Ah! I spent an embarrassing amount of time the other day looking for that, but I guess mostly annoyed that that isn't exposed on str and only u8.
TheBlueMatt
force-pushed
the
2021-05-no-control-chars
branch
from
81ff7c8 to
1c4c910
Compare
jkczyz
approved these changes
May 13, 2021
TheBlueMatt
force-pushed
the
2021-05-no-control-chars
branch
from
1c4c910 to
f0084e1
Compare
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
==========================================
- Coverage 90.48% 90.46% -0.02%
==========================================
Files 59 59
Lines 29788 29789 +1
==========================================
- Hits 26953 26950 -3
- Misses 2835 2839 +4
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed that this wasn't fully resolved in #919 (comment)