Log payment hash of the HTLC that causes a force closure #4003
Conversation
|
👋 I see @joostjager was un-assigned. |
|
Rather than (only) logging it, can we pipe it back through to the |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4003 +/- ##
=======================================
Coverage 88.84% 88.85%
=======================================
Files 175 175
Lines 127682 127710 +28
Branches 127682 127710 +28
=======================================
+ Hits 113440 113472 +32
+ Misses 11681 11674 -7
- Partials 2561 2564 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added PaymentHash to the enum variant and tried to fix the tests, but there are seems to be some tests that do not have payment hash to assert on. I commented them out, but would be glad if someone could assist with fixing them. |
yellowred
force-pushed
the
add_htlc_payment_hash_log
branch
from
1b41664 to
5687ac9
Compare
When LDK force closes a channel because of an HTLC time out, we would like to know the payment hash of the HTLC so we can debug the reason for time out. Co-authored-by: Matt Corallo <[email protected]>
TheBlueMatt
force-pushed
the
add_htlc_payment_hash_log
branch
from
5687ac9 to
b1cff7a
Compare
|
Fixed the tests and addressed pending feedback. |
When an HTLC timing out causes a channel to force-close, its useful to have the payment hash available in a programatic way so that it is always available for debugging. Thus, here, it is added to `ClosureReason::HTLCsTimedOut` for inclusion in `Event::ChanelClosed`. Co-authored-by: Matt Corallo <[email protected]>
TheBlueMatt
force-pushed
the
add_htlc_payment_hash_log
branch
from
b1cff7a to
e77c83d
Compare
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
When LDK force closes a channel because of an HTLC time out, we would like to know the payment hash of the HTLC so we can debug the reason for time out.