Add release notes and bump version for 0.1.3 #3759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @jkczyz was un-assigned. |
jkczyz
approved these changes
Apr 30, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
✅ Added second reviewer: @jkczyz |
|
✅ Added second reviewer: @wpaulino |
benthecarman
approved these changes
Apr 30, 2025
joostjager
approved these changes
Apr 30, 2025
CHANGELOG.md
Outdated
| # 0.1.3 - Apr 30, 2025 - "Routing Unicode in 2025" | ||
|
|
||
| ## Bug Fixes | ||
| * `Event::InvoiceRecieved` is now only generated once for each `Bolt12Invoice` |
There was a problem hiding this comment.
PR desc says it is specifically when manually_handle_bolt12_invoice is enabled. But statement as it is true too then.
There was a problem hiding this comment.
Sure, InvoiceReceived is only generated if manually_handle_bolt12_invoice is set :).
There was a problem hiding this comment.
Trying to make the best of a changelog review...
TheBlueMatt
force-pushed
the
2025-04-0.1.3-relnotes
branch
from
ccd9444 to
0edff53
Compare
|
Fixed the typo Joost caught :( |
$ git diff-tree -U1 ccd94445c 0edff530e
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0d7c9d5d6..80652dcb7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,3 +3,3 @@
## Bug Fixes
- * `Event::InvoiceRecieved` is now only generated once for each `Bolt12Invoice`
+ * `Event::InvoiceReceived` is now only generated once for each `Bolt12Invoice`
received matching a pending outbound payment. Previously it would be provided |
joostjager
approved these changes
Apr 30, 2025
wpaulino
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.