[0.0.123-bindings] Move the public channel state API into a new module #3092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our "what is the channel's current state" structs have slowly grown to be rather nontrivial, and now include eight structs with many fields. Thus, it makes sense to pull them out of `ln::channelmanager` and into their own module. This also makes things easier for the C bindings which don't support `pub use` from a private module.
1f616c0 moved a handful of structs to the new `channel_state.rs` but forgot to move their serialization logic with them, which is corrected here.
jkczyz
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3089 and #3091 backported to the 123-bindings branch for lightningdevkit/ldk-c-bindings#125