cfg-gate async signing logic #2792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover. Here we add a new `async_signing` cfg flag and use it to gate all the new logic from lightningdevkit#2558 effectively reverting commits 1da2929 through 014a336.
wpaulino
approved these changes
Dec 14, 2023
shaavan
reviewed
Dec 14, 2023
Member
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
ACK modulo nit
The function, set_channel_signer_available is only used within async_signer_tests and hence its usage is limited within the context of
cfg(aync_signing).
Would it make sense to gate this function, too?
Contributor
|
It's part of the test suite so it doesn't matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are intending to release without having completed our async signing logic, which sadly means we need to cfg-gate it to ensure we restore the previous state of panicking on signer errors, rather than putting us in a stuck state with no way to recover.
Here we add a new
async_signingcfg flag and use it to gate all the new logic from #2558 effectively reverting commits 1da2929 through014a336.