Update tokio version to the latest to avoid tokio versions with security bugs #2790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity bugs. This commit will set tokio version requirement to >=1.35.0, <2.0.0 to avoid versions with security issues (https://rustsec.org/packages/tokio.html).
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2790 +/- ##
==========================================
- Coverage 88.64% 88.59% -0.05%
==========================================
Files 115 115
Lines 91894 91894
Branches 91894 91894
==========================================
- Hits 81458 81416 -42
- Misses 7953 7985 +32
- Partials 2483 2493 +10 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
approved these changes
Dec 13, 2023
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Sure, though worth noting none of the security issues in Tokio thus far have impacted our usage of it (and until we bumped the MSRV we relied on a previous version of it to meet MSRV).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will set tokio version requirement to >=1.35.0, <2.0.0 to avoid versions with security issues. Version 1.35.0 is already normally installed when
cargo updateis executed. This PR is just makes it an error to install a version lower than that.