Skip to content

Conversation

@shaavan
Copy link
Member

@shaavan shaavan commented Nov 10, 2023

Resolves #2712

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e40e5f) 88.80% compared to head (dce514e) 88.66%.
Report is 25 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2726      +/-   ##
==========================================
- Coverage   88.80%   88.66%   -0.15%     
==========================================
  Files         113      113              
  Lines       89170    89370     +200     
  Branches    89170    89370     +200     
==========================================
+ Hits        79188    79236      +48     
- Misses       7729     7882     +153     
+ Partials     2253     2252       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaavan
Copy link
Member Author

shaavan commented Nov 14, 2023

Updated from pr2726.01 -> pr2726.02 (diff)
Addressed @TheBlueMatt comments

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No real reason to wait for another review here, it doesn't change the error message/allocation pattern, only adds a new log, which while it is an ERROR level log it is in response to a user action which shouldn't really happen in production except in rare races.

@TheBlueMatt TheBlueMatt merged commit 185fbc1 into lightningdevkit:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log when we refuse to forward an intercepted HTLC

3 participants