Remove channel monitor sync in progress log #2669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
- Coverage 89.04% 89.02% -0.02%
==========================================
Files 112 112
Lines 87229 87525 +296
Branches 87229 87525 +296
==========================================
+ Hits 77674 77922 +248
- Misses 7319 7363 +44
- Partials 2236 2240 +4
☔ View full report in Codecov by Sentry. |
valentinewallace
previously approved these changes
Oct 18, 2023
TheBlueMatt
reviewed
Oct 18, 2023
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
If its super spammy we might consider removing it entirely instead, IMO.
This log is super spammy for us and isn't very useful.
benthecarman
force-pushed
the
trace-sync-progress
branch
from
cb235e9 to
439f916
Compare
Contributor
Author
|
removed log instead |
benthecarman
changed the title
tnull
reviewed
Oct 19, 2023
| log_debug!(self.logger, "A Channel Monitor sync is still in progress, refusing to provide monitor events!"); | ||
| } else { | ||
| if !is_pending_monitor_update || monitor_state.last_chain_persist_height.load(Ordering::Acquire) + LATENCY_GRACE_PERIOD_BLOCKS as usize <= self.highest_chain_height.load(Ordering::Acquire) { | ||
| if is_pending_monitor_update { |
Contributor
There was a problem hiding this comment.
Given we have this if depending on is_pending_monitor_update following right away, it might be cleaner to maintain a top-level if ... else here?
Contributor
Author
There was a problem hiding this comment.
Any way I try this ends up being more messy.
tnull
approved these changes
Oct 30, 2023
TheBlueMatt
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log is super spammy for us and isn't very useful