Skip to content

Conversation

@dunxen
Copy link
Contributor

@dunxen dunxen commented May 9, 2023

Just some follow-ups to address nits at #1794 (review).

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Patch coverage: 39.13% and project coverage change: -0.01 ⚠️

Comparison is base (0ecb4b0) 90.94% compared to head (33e901a) 90.94%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
- Coverage   90.94%   90.94%   -0.01%     
==========================================
  Files         104      104              
  Lines       52741    52744       +3     
  Branches    52741    52744       +3     
==========================================
  Hits        47966    47966              
- Misses       4775     4778       +3     
Impacted Files Coverage Δ
lightning/src/util/ser.rs 85.10% <36.36%> (-1.83%) ⬇️
lightning/src/ln/msgs.rs 85.13% <100.00%> (+0.66%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit f569e9f into lightningdevkit:main May 9, 2023
@dunxen dunxen deleted the 2023-05-dfmsgfollowups branch May 10, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants