Only import lightning::io if futures are enabled

[douglaz]

Another option is to import under #[cfg(feature = "futures")]

Rationale: avoids unnecessary warnings on check and clippy with default features

[codecov-commenter]

Codecov Report

Base: 87.33% // Head: 87.32% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (19ef2bb) compared to base (46fd703).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2050      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         101      101              
  Lines       44364    44364              
  Branches    44364    44364              
==========================================
- Hits        38747    38743       -4     
- Misses       5617     5621       +4     

Impacted Files	Coverage Δ
lightning-background-processor/src/lib.rs	81.67% <ø> (ø)
lightning/src/chain/onchaintx.rs	85.61% <0.00%> (-0.69%)	⬇️
lightning/src/ln/functional_tests.rs	97.27% <0.00%> (-0.02%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TheBlueMatt]

Thanks!

[douglaz]

@TheBlueMatt the macos builds failed, but I don't see an error. Do you know what happened?

[TheBlueMatt]

Hmm, yea, I dont see an error there, either, I think its just CI being flaky as usual. I kicked those jobs so they should retest.