Use even types for opt_anchors #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents downgrading to older versions of LDK that are not capable of supporting anchor channels when the field is serialized (i.e., opt_anchors is `Some`).
wpaulino
force-pushed
the
prevent-downgrade-from-anchors
branch
from
9bae573 to
b578480
Compare
wpaulino
commented
Dec 7, 2022
TheBlueMatt
approved these changes
Dec 7, 2022
dunxen
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents downgrading to older versions of LDK that are not capable of supporting anchor channels when the field is serialized (i.e., opt_anchors is
Some).This was pointed out in #1825 (comment).