Drop return value from Filter::register_output
#1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2022-08-drop-register-output-return
branch
from
a6c9f08 to
2246d65
Compare
TheBlueMatt
reviewed
Aug 15, 2022
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Love this for us
Basically looks good to me, just wanted to document the reasoning for some of the changes
This commit removes the return value from `Filter::register_output` as creating a suitable value almost always entails blocking operations (e.g., lookups via network request), which however conflicts with the requirement that user calls should avoid blocking calls at all cost. Removing the return value also rendered quite a bit of test code for dependent transaction handling superfluous, which is therefore also removed with this commit.
tnull
force-pushed
the
2022-08-drop-register-output-return
branch
from
c1ad123 to
c562f33
Compare
Contributor
Author
|
Squashed commits and updated commit message. |
valentinewallace
approved these changes
Aug 15, 2022
TheBlueMatt
approved these changes
Aug 15, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the methods implementing the
Filterinterface should never block, returning a spending transactions fromregister_outputwas practically infeasible.This PR hence removes the return value and cleans up the interface.
Since I'm already 'here', I now added another commit addressing a slight doc nit regarding
Confirm::get_relevant_txids()I had for some time now.