Have find_route take a NetworkGraph instead of a ReadOnly one
#1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because downstream languages are often garbage-collected, having the user directly allocate a `ReadOnlyNetworkGraph` and pass a reference to it to `find_route` often results in holding a read lock long in excess of the `find_route` call. Worse, some languages (like JavaScript) tend to only garbage collect when other code is not running, possibly leading to deadlocks.
jkczyz
approved these changes
Jun 29, 2022
wpaulino
approved these changes
Jun 29, 2022
dunxen
approved these changes
Jun 29, 2022
G8XSU
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because downstream languages are often garbage-collected, having
the user directly allocate a
ReadOnlyNetworkGraphand pass areference to it to
find_routeoften results in holding a readlock long in excess of the
find_routecall. Worse, some languages(like JavaScript) tend to only garbage collect when other code is
not running, possibly leading to deadlocks.
Note that I'm gonna take this in the 0.0.108 bindings in Java