Expand chain::Listen trivially to accept filtered block data
#1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
previously approved these changes
Apr 26, 2022
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Does this close #1128 or is more work needed? Also maybe BIP 157/158 should be called out explicitly in the Listen docs as supported
The `chain::Listen` interface provides a block-connection-based alternative to the `chain::Confirm` interface, which supports providing transaction data at a time separate from the block connection time. For users who are downloading the full headers tree (e.g. from a node over the Bitcoin P2P protocol) but who are not downloading full blocks (e.g. because they're using BIP 157/158 filtering) there is no API that matches exactly their event stream - `chain::Listen` requries full blocks for each block, `chain::Confirm` requires breaking each connection event into two calls. Given its incredibly trivial to take a `TransactionData` in addition to a `Block` in `chain::Listen` we do so here, adding a default-implementation `block_connected` which simply creates the `TransactionData`, which ultimately all of the `chain::Listen` implementations currently do anyway. Closes lightningdevkit#1128.
TheBlueMatt
force-pushed
the
2022-04-listen-filtered-blocks
branch
from
a41cbaa to
d629a7e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
- Coverage 90.88% 90.87% -0.02%
==========================================
Files 75 75
Lines 41474 41475 +1
Branches 41474 41475 +1
==========================================
- Hits 37695 37691 -4
- Misses 3779 3784 +5
Continue to review full report at Codecov.
|
arik-so
approved these changes
Apr 27, 2022
valentinewallace
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chain::Listeninterface provides a block-connection-basedalternative to the
chain::Confirminterface, which supportsproviding transaction data at a time separate from the block
connection time.
For users who are downloading the full headers tree (e.g. from a
node over the Bitcoin P2P protocol) but who are not downloading
full blocks (e.g. because they're using BIP 157/158 filtering)
there is no API that matches exactly their event stream -
chain::Listenrequries full blocks for each block,chain::Confirmrequires breaking each connection event into twocalls.
Given its incredibly trivial to take a
TransactionDatainaddition to a
Blockinchain::Listenwe do so here, adding adefault-implementation
block_connectedwhich simply creates theTransactionData, which ultimately all of thechain::Listenimplementations currently do anyway.
Closes #1128.