Store override counterparty handshake limits until we enforce them #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently allow users to provide an `override_config` in `ChannelManager::create_channel` which it seems should apply to the channel. However, because we don't store any of it, the only parts which we apply to the channel are those which are set in the `Channel` object immediately in `Channel::new_outbound` and used from there. This is great in most cases, however the `UserConfig::peer_channel_config_limits` `ChannelHandshakeLimits` object is used in `accept_channel` to bound what is acceptable in our peer's `AcceptChannel` message. Thus, for outbound channels, we are given a full `UserConfig` object to "override" the default config, but we don't use any of the handshake limits specified in it. Here, we move to storing the `ChannelHandshakeLimits` explicitly and applying it when we receive our peer's `AcceptChannel`. Note that we don't need to store it anywhere because if we haven't received an `AcceptChannel` from our peer when we reload from disk we will forget the channel entirely anyway.
Codecov Report
@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
- Coverage 90.41% 90.41% -0.01%
==========================================
Files 71 71
Lines 38359 38364 +5
==========================================
+ Hits 34684 34686 +2
- Misses 3675 3678 +3
Continue to review full report at Codecov.
|
arik-so
approved these changes
Feb 10, 2022
valentinewallace
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently allow users to provide an
override_configinChannelManager::create_channelwhich it seems should apply to thechannel. However, because we don't store any of it, the only parts
which we apply to the channel are those which are set in the
Channelobject immediately inChannel::new_outboundand usedfrom there.
This is great in most cases, however the
UserConfig::peer_channel_config_limitsChannelHandshakeLimitsobject is used in
accept_channelto bound what is acceptable inour peer's
AcceptChannelmessage. Thus, for outbound channels, weare given a full
UserConfigobject to "override" the defaultconfig, but we don't use any of the handshake limits specified in
it.
Here, we move to storing the
ChannelHandshakeLimitsexplicitlyand applying it when we receive our peer's
AcceptChannel. Notethat we don't need to store it anywhere because if we haven't
received an
AcceptChannelfrom our peer when we reload from diskwe will forget the channel entirely anyway.