Expand tests for Features::to_context #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported by a user when trying to send a payment using the LDK sample (specifically during route generation when translating a Features from one context to another) The problem was we didn't check T::KNOWN_FEATURE_MASK vec length before indexing into it, due likely to the assumption that known feature vec lengths are the same across contexts, when they may not be
Codecov Report
@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
- Coverage 90.78% 90.75% -0.03%
==========================================
Files 60 60
Lines 30914 30909 -5
==========================================
- Hits 28064 28053 -11
- Misses 2850 2856 +6
Continue to review full report at Codecov.
|
When there are fewer known `from` feature bytes than known `to` feature bytes, an index-out-of-bounds error can occur if the `from` features have unknown features set in a byte past the greatest known `from` feature byte.
jkczyz
force-pushed
the
2021-known-features-mask
branch
from
9b71f63 to
8723348
Compare
TheBlueMatt
approved these changes
Jul 15, 2021
valentinewallace
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are fewer known
fromfeature bytes than knowntofeature bytes, an index-out-of-bounds error can occur if thefromfeatures have unknown features set in a byte past the greatest knownfromfeature byte. This may happen when parsing an invoice, for instance.This PR adds a test for the fix in #1002. It also removes some unnecessary test code.