Don't panic if broadcast_transaction fails due to duplicate broadcasts #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
approved these changes
May 13, 2021
Contributor
|
Will merge once lightningdevkit/rust-lightning#919 is merged upstream. cc: @TheBlueMatt |
Contributor
Author
Sg, I'll add another commit updating the upstream commit at that point too. |
Contributor
Shouldn't be needed as of #8. |
TheBlueMatt
reviewed
May 13, 2021
valentinewallace
force-pushed
the
fix-broadcast-tx-panic
branch
from
3a4ff94 to
3a87d0a
Compare
jkczyz
reviewed
May 15, 2021
or from broadcasting too early.
valentinewallace
force-pushed
the
fix-broadcast-tx-panic
branch
from
3a87d0a to
198a839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightningdevkit/rust-lightning#919