Make shutdown procedure more robust #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had to configure enormous syncing timeouts as the BDK wallet syncing would hold a central mutex that could lead to large parts of event handling and syncing locking up. Here, we drop the configured timeouts considerably across the board, since such huge values are hopefully not required anymore.
|
I've assigned @wpaulino as a reviewer! |
wpaulino
reviewed
Jul 8, 2025
src/lib.rs
Outdated
| self.peer_manager.disconnect_all_peers(); | ||
|
|
||
| // Ensure we process the broadcast queue one last time, as we may have generated | ||
| // force-closures during peer disconnection. |
There was a problem hiding this comment.
If we're force closing due to a disconnection, then we never broadcast the funding transaction to begin with, so we shouldn't need to broadcast a commitment transaction. I assume the behavior you were seeing will end up getting fixed by lightningdevkit/rust-lightning#3881.
There was a problem hiding this comment.
Ah, okay. I expected this but wasn't sure if we could lean on it. Will drop the commit then.
Previously, we used to a channel to indicate that the background processor task has been stopped. Here, we rather just await the task's `JoinHandle` which is more robust in that it avoids a race condition.
.. we provide finer-grained logging after each step of `stop`.
tnull
force-pushed
the
2025-07-make-shutdown-more-robust
branch
from
7c773a1 to
c3d6161
Compare
wpaulino
approved these changes
Jul 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few improvements to our shutdown logic. Most notably, we now switch our 'shutdown' signal for the background event processor from using channels to just keeping the
JoinHandle, which also gets rid of a potential race condition. Moreover, we attempt to clear the broadcast queue one last time before we shut down.