Fix CLN crash by waiting for block height sync before channel open #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
approved these changes
Jul 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure CLN block height is synced before opening channel
This adds a loop that waits for
cln_client.getinfo().blockheight > 0before opening the channel.Without this, CLN may crash when persisting the channel if the internal block height hasn't been updated yet. The crash happens because CLN checks whether the current block height is greater than the channel's
first_blocknum, and if not, it fails an assertion.This typically occurs when the chain starts and blocks are mined quickly, causing CLN to miss the update before the channel open process begins.
For more context, see comment.
fix #527