Skip to content

Forward SIGTERM and SIGINT down to java process in wrapper script #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Forward SIGTERM and SIGINT down to java process in wrapper script #880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22671b4
Forward SIGTERM and SIGINT down to java process in wrapper script
sake May 7, 2021
60f6a34
Add comment on rational behind trap code in shell wrapper
sake May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion browsermob-dist/src/main/scripts/browsermob-proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,18 @@ then
JAVACMD="java"
fi

# start process in the background and handle SIGTERM/SIGINT
# see https://veithen.io/2014/11/16/sigterm-propagation.html
trap 'kill -TERM $PID' TERM INT
"$JAVACMD" $JAVA_OPTS \
-Dapp.name="browsermob-proxy" \
-Dbasedir="$BASEDIR" \
-jar "$BASEDIR/lib/browsermob-dist-${project.version}.jar" \
"$@"
"$@" &
PID=$!
wait $PID
trap - TERM INT
wait $PID

# if we couldn't find java, print a helpful error message
if [ $? -eq 127 ]
Expand Down