Set 'expires' to null for session cookies

[madoni]

Hi,
I noticed that the generated har contains invalid timestamp values for session cookies. Something like:
"expires" : "292269009-11-24T08:44:55.386-05:00",.
This results in exceptions while parsing the har file.
I realize this fix might be too simplistic... am open to suggestions!

Thanks!

[jekh]

Thanks @madoni. I looked into this and it turns out, in addition to the issue you noticed, the cookie.maxAge() field was not being treated properly. The netty docs say it is in seconds, but we were treating it like milliseconds. So I created PR #355 which fixes the issue you spotted and the ms mismatch. Could you give that branch a try and see if it fixes your issue? If so I'll merge it in.

[madoni]

Hey @jekh, yes I think that should sort it out.
As long as the expires value for session cookies is null, it shouldn't appear in the corresponding har entry.

[jekh]

Great. I'll close this PR now that the other one has been merged. Thanks for discovering this, @madoni!

[madoni]

Awesome! Glad I could contribute... My first attempt!

On Fri, Jan 1, 2016, 10:07 PM Jason Hoetger [email protected]
wrote:

Closed #354 #354.

—
Reply to this email directly or view it on GitHub
#354 (comment).