Backport macros to support Scala 2.10.x on master branch #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @rossabaker, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
hseeberger
pushed a commit
that referenced
this pull request
Apr 25, 2014
Backport macros to support Scala 2.10.x on master branch
Contributor
|
Pretty awesome!! |
|
Thank you! |
Atry
added a commit
to Atry/scala-logging
that referenced
this pull request
Jul 1, 2023
…t-best-practice-deploy Suppress error when GITHUB_PERSONAL_ACCESS_TOKEN is not present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Scala 2.10 without any modification to the API or specs. This will enable libraries that migrate to scala-logging-2.x to continue to cross build for Scala 2.10 and 2.11 without conditionals in the build or creating their own copy of the
Loggingtrait.Relates to #1, #4, #13