unix: fix uv_getrusage() ru_maxrss reporting #3721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
reviewed
Aug 21, 2022
santigimeno
approved these changes
Aug 21, 2022
Member
santigimeno
left a comment
santigimeno
left a comment
There was a problem hiding this comment.
LGTM making sure it leaves out iOS
cjihrig
approved these changes
Aug 21, 2022
Most platforms report it in kilobytes but macOS and Solaris report it in bytes and pages respectively. Fixes: nodejs/node#44332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most platforms report it in kilobytes but macOS and Solaris report it in
bytes and pages respectively.
Fixes: nodejs/node#44332
Windows, Linux and (Free|Net|Open)BSD all report kilobytes.