This repository was archived by the owner on Oct 18, 2023. It is now read-only.
Async ResultBuilder #532
Merged
Async ResultBuilder #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
full-async-builder
branch
from
4097740 to
d1e9845
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
DatabaseandResultBuildertrait from full async operation.Instead of taking a mutable reference to a
ResultBuilder, theDatabasetrait takes ownership of theResultBuilder. Thefinnalizemethod can be used to return the result one way or another, for example with aoneshot::channel. This new model allows the Builder to be driven completely asynchronously, in sync and async context.