Make pubsub option emitSelf configurable

[a1300]

First and foremost: Thanks for this great package and the hard work! 👍

• Version: 0.26.0
• Platform: Linux Kubuntu-18 4.18.0-25-generic
• Subsystem:

Type: Feature

Severity: Low

Description:

Currently is the option emitSelf for pubsub packages (libp2p/js-libp2p-floodsub and ChainSafe/gossipsub-js) hardcoded in the code.

js-libp2p/src/pubsub.js

Line 10 in fd738f9

const pubsub = new Pubsub(node, { emitSelf: true })

Both pubsub packages support the emitSelf option. It would be nice to add the option to specify if self-published messages should be received.

Example:

export class Bundle extends libp2p {
  constructor(_options) {
    const defaults = {
      modules: {
        transport: [TCP],
        streamMuxer: [Mplex],
        connEncryption: [SECIO],
        peerDiscovery: [Bootstrap],
        dht: DHT,
        pubsub: GossipSub,
      },
      config: {
        pubsub: {
          enabled: true,
+         emitSelf: false,
        },
      },
    };
    super(defaultsDeep(_options, defaults));
  }

Steps to reproduce the error:

[a1300]

If this feature request is granted I would like to have this issue assigned to me 🙂

[jacobheun]

Yes, we should pass the configuration into the Pubsub initialization. We should account for other Pubsub options as well when doing this, such as the strict signing and verification params https://github.com/libp2p/js-libp2p-pubsub/blob/v0.2.0/src/index.js#L30-L31. I'd expect the whole pubsub config object to get passed.

[jacobheun]

Fixed in #404