Give GTTag Some Love #253
Give GTTag Some Love #253
Conversation
… and -(NSString *)targetType to properties.
(The previous commit accidentally made those changes, this just updates the Project Settings)
|
Hot. While you're in here could you add some documentation to the properties? |
ghost
assigned
| @@ -38,13 +38,13 @@ | |||
|
|
|||
| @property (nonatomic, readonly, strong) GTSignature *tagger; | |||
|
|
|||
| // The underlying `git_object` as a `git_tag` object. | |||
| - (git_tag *)git_tag __attribute__((objc_returns_inner_pointer)); | |||
| @property (nonatomic,strong) NSString *message; | |||
There was a problem hiding this comment.
Unless I'm misreading the implementation, these don't seem to be writable (but the declarations say they are).
There was a problem hiding this comment.
Good spot, these should be readonly.
Also a space between each attribute please, (nonatomic, readonly).
|
✨ |
| @@ -54,4 +59,9 @@ | |||
| // Returns the found object or nil on error. | |||
| - (id)objectByPeelingTagError:(NSError **)error; | |||
|
|
|||
| // The underlying `git_object` as a `git_tag` object. | |||
| - (git_tag *)git_tag __attribute__((objc_returns_inner_pointer)); | |||
|
|
|||
There was a problem hiding this comment.
All this whitespace is unnecessary.
|
🎆 Just a few notes. Thanks for cleaning up this legacy crud! |
|
🎯 |
| } | ||
|
|
||
| - (NSString *)name { | ||
| return [NSString stringWithUTF8String:git_tag_name(self.git_tag)]; | ||
| return @(git_tag_name(self.git_tag)); | ||
| } | ||
|
|
||
| - (GTObject *)target { | ||
| git_object *t; |
There was a problem hiding this comment.
Can we fix the rogue spacing here?
There was a problem hiding this comment.
Sorry, I don't see it. :(
There was a problem hiding this comment.
I believe it's a tabs vs spaces issue. Looks like this used to use spaces at some point.
|
🍦 So close… just gotta tidy up some of the old spacing in here. |
|
Let's hope this commit fixed it. Not sure though. |
| if(gitError < GIT_OK) return nil; | ||
| return [GTObject objectWithObj:(git_object *)t inRepository:self.repository]; | ||
| if (gitError < GIT_OK) return nil; | ||
|
|
There was a problem hiding this comment.
No need to add this whitespace.
|
We can run with it. Just need to tighten up one more bit of whitespace then this is good to |
.
|
🚢 |
|
💥🐫 |
|
Yay! Thanks for working with me on this! |
|
No problem at all! Thanks for contributing! |
Give GTTag Some Love
-(NSString *)message,-(NSString *)name,-(GTObject *)target, and-(NSString *)targetTypeto properties.