Skip to content

[iOS] RN 0.71.0-rc.5 + Reanimated 3.0.0-rc.8/commit +/- Hermes +/- new arch #1310

@leotm

Description

@leotm

Xcode Version 14.2 (14C18), debug-mode only, not tested Release

Hermes, New Arch, 3.0.0-rc.8

Screenshot 2022-12-20 at 12 44 59

Screenshot 2022-12-20 at 12 45 31

/Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedHermesRuntime.cpp:44:27: error: return type of virtual function 'getRuntime' is not covariant with the return type of the function it overrides ('facebook::jsi::Runtime &' is not derived from 'facebook::hermes::HermesRuntime &')
  facebook::jsi::Runtime &getRuntime() override {
  ~~~~~~~~~~~~~~~~~~~~~~~~^
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedHermesRuntime.cpp:20:
/Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native/ReactCommon/hermes/inspector/RuntimeAdapter.h:40:26: note: overridden virtual function is here
  virtual HermesRuntime &getRuntime() = 0;
          ~~~~~~~~~~~~~~~^
/Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedHermesRuntime.cpp:48:55: error: only virtual member functions can be marked 'override'
  facebook::hermes::debugger::Debugger &getDebugger() override {
                                                      ^~~~~~~~~
/Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedHermesRuntime.cpp:87:57: error: no viable conversion from 'facebook::hermes::HermesRuntime' to 'facebook::hermes::inspector::chrome::DebugSessionToken' (aka 'int')
  facebook::hermes::inspector::chrome::disableDebugging(*runtime_);
                                                        ^~~~~~~~~
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedHermesRuntime.cpp:21:
/Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native/ReactCommon/hermes/inspector/chrome/Registration.h:38:48: note: passing argument to parameter 'session' here
extern void disableDebugging(DebugSessionToken session);
                                               ^
3 errors generated.

similar to

see

Hermes, New Arch, 3.0.0-rc.8

Screenshot 2022-12-20 at 12 55 50

/Users/leo/Documents/GitHub/react-native-template-new-architecture/node_modules/react-native-reanimated/Common/cpp/ReanimatedRuntime/ReanimatedRuntime.cpp:14:10: fatal error: 'jsi/JSCRuntime.h' file not found
#include <jsi/JSCRuntime.h>
         ^~~~~~~~~~~~~~~~~~
1 error generated.

Hermes, New Arch, 3.0.0-rc.8

Same/prev error ^


Hermes, New Arch, 36262db9ad74affeb37c5f1ab5f90ac4d33d1a11

Screenshot 2022-12-20 at 14 18 50

In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/MyApp/main.m:3:
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/MyApp/AppDelegate.h:1:
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Public/React-RCTAppDelegate/RCTAppDelegate.h:14:
/Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Private/React-Core/React/RCTCxxBridgeDelegate.h:8:10: fatal error: 'memory' file not found
#include <memory>
         ^~~~~~~~
While building module 'ReactCommon' imported from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Public/React-RCTAppDelegate/RCTAppDelegate.h:16:
In file included from <module-includes>:1:
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Public/ReactCommon/ReactCommon-umbrella.h:13:
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Public/ReactCommon/react/bridging/Array.h:10:
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Public/ReactCommon/react/bridging/Base.h:10:
In file included from /Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Public/ReactCommon/react/bridging/Convert.h:10:
/Users/leo/Documents/GitHub/react-native-template-new-architecture/ios/Pods/Headers/Public/hermes-engine/jsi/jsi.h:10:10: fatal error: 'cassert' file not found
#include <cassert>
         ^~~~~~~~~
1 error generated.
2 errors generated.

Hermes, New Arch, 36262db9ad74affeb37c5f1ab5f90ac4d33d1a11

Hermes, New Arch, 36262db9ad74affeb37c5f1ab5f90ac4d33d1a11

Metadata

Metadata

Assignees

No one assigned

    Labels

    depsNormal dependencies needed at runtimehermesJS engine for RN (optimised: TTI, size, RAM)iosNative iOS changes (Swift, C++, CocoaPods)new archFabric / TurboModules / JSI changesp: Software Mansionreact nativereact-native-community.github.io/upgrade-helper

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions