Skip to content

Conversation

@sjpotter
Copy link
Collaborator

@sjpotter sjpotter commented Nov 9, 2023

Description

Describe your pull request here

redoes the redis socket typing to make it more consistent and easier to use in other types. Had difficulties with typescript checking, as its now consistently uses interfaces instead of a mix of type and interfaces, seems to work better for me.

but to achieve that, had to rename one member as otherwise would have clashes.

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@sjpotter sjpotter requested a review from leibale November 9, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant