Fix some bugs in replay #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBEber
commented
Sep 12, 2020
TheBEber
commented
- Adapting replay speed to recorded scenario
- Concatenation of TimeElapsed cannot be done as proposed, need to be splitted after another event (to be able to calculate the time during which a button has been pressed, and replay it exactly) (exemple of a jump, when we start/stop pushing a button needs to be exact, in the exemple in the commit message, we may consider the button has been pressed for twice the real time (repends of the implementation for sure...))
- Gui start state needs to be recorded (windows size/scale & position of internal elements -> saved for now in imgui.ini, but needs to be reset to the state before the start of recording in order to replay it correctly) ( this commit may not be the good way to handle it, but it is more for illustration of the problem)
- Some bug still exists : mouse clic does not seems to work for windows resize (Resize event to be handled) and internal sub-windows movement/resizing does not seems to work either
added 3 commits
September 12, 2020 17:42
In the case:
- Button pushed
- TimeElapsed
- Button released
- TimeElapsed
<--- now the game state knows the button is release
- TimeElapsed
- TimeElapsed
- Something else happened
Otherwise, after compression in replay it would become
- Button pushed
- TimeElapsed
- Button released
- TimeElapsed (compressed, so x3)
<--- now the game state knows the button is release
- Something else happened
Such that the timings are incorrects
Arguments of the display may have changed between save/replay Here is some way to do it. Maybe not the best way to, my idea was to expose the problem here. Another problem that is still not fixed here: - Windows are not resized / Moved by replay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.