Bugfix/settingsreset #179
Merged
Bugfix/settingsreset #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod_form.php
Outdated
| /** | ||
| * constructor | ||
| * @see moodleform_mod::moodleform_mod | ||
| */ |
There was a problem hiding this comment.
I think the parent already does this could you double-check if this is necessary? :)
There was a problem hiding this comment.
yes, it is unnecessary :)
| $post = new backup_nested_element('post', ['id'], [ | ||
| 'parent', 'userid', 'created', 'modified', | ||
| 'mailed', 'message', 'messageformat', 'attachment']); | ||
| 'mailed', 'message', 'messageformat', 'attachment', ]); |
There was a problem hiding this comment.
misses reviewed and time reviewed in case we want to also backup that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #177
Found problem: While importing a course into another, moodle uses the backup-functions from a module. The stepslib in moodleoverflow defines, which columns of a datatable are being backed-up. In that definition some columns of moodleoverflow table where missing, including the grademax and anonymous setting.
Solution: Adding the columns to the backup-function. After that the anonymous and grademax settings functions as they should