WIP Fix/attachmentnotfound - files are not properly deleted

[NinaHerrmann]

No description provided.

[pejhab]

Thanks for following this up.
Shouldn't this be a priority as it breaks a core feature which makes a lot of forums unusable?

[NinaHerrmann]

Sorry to disappoint you, but if we are working in the same week, it is a priority...

[pejhab]

I am not disappointed. I trust you. :-)

[NinaHerrmann]

in this way you delete the db enrty, but NOT the actual file in the folder (db is just for where the file can be found)
Change to somthing like

$fs = get_file_storage();

// Prepare file record object
$fileinfo = array(
    'component' => 'mod_mymodule',
    'filearea' => 'myarea',     // usually = table name
    'itemid' => 0,               // usually = ID of row in table
    'contextid' => $context->id, // ID of context
    'filepath' => '/',           // any path beginning and ending in /
    'filename' => 'myfile.txt'); // any filename

// Get file
$file = $fs->get_file($fileinfo['contextid'], $fileinfo['component'], $fileinfo['filearea'], 
        $fileinfo['itemid'], $fileinfo['filepath'], $fileinfo['filename']);

// Delete it if it exists
if ($file) {
    $file->delete();
}

(https://docs.moodle.org/dev/File_API#Delete_file)