Fixes learnweb/moodle-mod_moodleoverflow#75 #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is faster, but for our dataset, it's still taking more than 8 minutes to return an empty set for the first of the two queries. Maybe split it into three or four single queries? Or the alternative query mentioned in the issue comment: #75 (comment). |
|
You are missing a semicolon. |
|
The alternative query is much harder to understand. I would go for readability/simplicity and split up the joins further. |
ziegenberg
reviewed
Apr 25, 2023
fixes phpunit errors Co-authored-by: Daniel Ziegenberg <[email protected]>
|
Sorry, I hope I can trust you on this one, as test are not failing :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed database issue in adhoc-task
tool_dataprivacy\task\process_data_request_taskby splitting query into two parts due to a never ending database request.