-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add redis, celery services to project #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bryangingechen
wants to merge
11
commits into
master
Choose a base branch
from
finalize-environment-tooling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28d2acd to
171016f
Compare
171016f to
41c8806
Compare
- Introduced a settings package with shared config, environment overrides, and default local export, including env-driven database setup and src/ path injection (qb_site/qb_site/settings/ base.py:1, qb_site/qb_site/settings/local.py:1, qb_site/qb_site/settings/ci.py:1, qb_site/qb_site/ settings/production.py:1, qb_site/qb_site/settings/__init__.py:1). - Registered dedicated Django apps and scaffolded their package structure to mirror the core/ syncer/analyzer/api responsibilities (qb_site/core/apps.py:1, qb_site/syncer/apps.py:1, qb_site/ analyzer/apps.py:1, qb_site/api/apps.py:1). - Wired the API namespace into the project URLs with a placeholder router ready for DRF endpoints (qb_site/qb_site/urls.py:1, qb_site/api/urls.py:1).
> Dockerized Dev Env - Added a slim Python 3.12 image that installs the project editable, exposes the repo via PYTHONPATH=/app, and runs migrations before runserver (Dockerfile:1, scripts/docker- entrypoint.sh:1). - Defined a compose stack with a Postgres 16 service, health checks, env passthrough, and a live-mounted web container (docker-compose.yml:1). .dockerignore:1 keeps the build lean, and .env.example:1 now lists DJANGO_SETTINGS_MODULE plus all required vars. Django Package Layout - Introduced qb_site/__init__.py:1 so the outer project directory is a proper package. - Registered apps as top-level modules (core, syncer, analyzer, api) to match Django’s default startproject layout and avoid import clashes when running manage.py (qb_site/qb_site/settings/ base.py:38, qb_site/core/apps.py:1, qb_site/syncer/apps.py:1, qb_site/analyzer/apps.py:1, qb_site/ api/apps.py:1). - Updated project URLs to include the API namespace via the new module path (qb_site/qb_site/ urls.py:6). Docs & Dependencies - Documented the Docker workflow in the README (README.md:39) and refreshed the migration plan to reflect the compose setup and app naming (docs/django_backend_plan.md:5). - Added psycopg[binary] so Postgres connections work out of the box (pyproject.toml:11); uv.lock picks up the resolved wheels.
41c8806 to
6907de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly written by Codex.
celery+redis will serve as a task runner for the project. I also made Codex CLI add various documentation, including
AGENTS.mdanddocs/design-decisions/.Depends on #59 and I also went ahead and put the v2 doc from #33 here so the AI could refer to it.