-
Notifications
You must be signed in to change notification settings - Fork 20
First commit of geometry rewrite. Mesh and MeshElement traits have be… #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en created. First steps towards geometry agnosticism.
…on of the default input) to Material<T: Mesh> or Material<Mesh2D> where necessary. From now on, any struct that implements the Mesh trait can be used to create a Material. Neat!
…duces correct distributions, reflection coefficients, and sputtering yield.
… 3D. Removed old commented out code throughout, and added a couple why-comments.
…. This was very difficult, and it's not in an amazing state, but it works and it compiles. The worst offender is not knowing how to share associated types between traits, so to make the material I have to clone and use the entire input file to avoid a circular reference between the InputFile and Geometry traits.
…e that it works and reproduces equivalent results from Mesh2D. 3D targets are now possible (with a lot of dev work)!
added mesh_0D input file
…into geometry_rewrite
… with the 0D feature, you just give the code an additional flag.
This feature is now complete. Changes from last commit:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en created. First steps towards geometry agnosticism.
Fixes #75 #77 #80
Description
This is a major rewrite of all the geometry routines. The plan is as follows;
Tests
cargo test and layered_geometry.toml have been run on this first commit.