-
Couldn't load subscription status.
- Fork 20
Created Mesh2d creator Python script #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file creates a Mesh2D set of triangles. Converts more familiar user inputs to the specific type of inputs needed for RustBCA
removed extraneous imports, made changing the number of floats displayed for numpy arrays easier
moved the commented out test code for seeing the example triangles to the bottom and wrote a description for it. Added what is returned to each of the function descriptions
values are now output with ending zeros as RustBCA wants
added triangle and rectangle specific functions. removed unneeded type checks in __init__.
added descriptions to triangle and rectangle functions
clarified a description
Added check that x and y min are less than x and y max
removed unnneeded import statements. fixed misspelling of energy
tested multiploygon shapes
Added timeit to see how long it takes to create mesh.
Added a particle species creator for the input file in python.
Removed some print statements in create_mesh2D and ran tests for a copper 50x50 micron ship
Removed custom function to make everything have ending zeros for toml. Now uses the toml encoder keyword
|
@Stephen-Armstrong I'm ready to close this and add the script if you think it's good to go |
|
I think it's good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Fixes # (issue)
Description
Please include a concise description of the change and how it addresses a relevant issue, including references, input files, and figures as relevant.
There is an added Python script called create_mesh2D.py. The script allows with simple commands to create a mesh2D object that contains all of the information required to print to a RustBCA input file and to put the information save the information in the .toml format of RustBCA. Includes functions to create N-gons, rectangles, and triangles.
Tests
Please describe how the changes in this pull request have been tested, including system information such as OS.
Windows 10. Replicated the boron nitride example with a similar number of triangles.