This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Check if bridge is available before sending an event #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for contributing to this repo, we will test this and get back to you. |
Contributor
|
This PR passed our internal testing, thanks again for finding and fixing this bug! |
Contributor
Author
|
Any ETA on the new release with this fix? |
Member
|
We're targeting a release this week for the next SDK version. |
Merged
Member
|
This is now available in 3.0.0. |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
#38
Describe the solution you've provided
For a solution, I have added a check if
self.bridgeis not nil before attempting to send an event. The nice thing is the callback that attempts to send the event gets called once the bridge is set and it successfully registers the listener.Describe alternatives you've considered
N/A
Additional context
N/A