This repository was archived by the owner on Oct 29, 2024. It is now read-only.
feat(iOS): Support user.country #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android already supports it
Contributor
|
Hi @Titozzz thanks for the PR, this change looks good! We'll do some testing and get this into the next release. |
torchhound
requested review from
torchhound
and removed request for
torchhound
Contributor
Author
|
Btw web and iOS use String, but android uses enum, and crashes on unknown country |
torchhound
approved these changes
Jan 17, 2020
Contributor
|
@Titozzz Thanks again for the PR, this change will go out in the next release very soon. |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Jan 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android already supports it
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.