Fix indirect streaming messages. #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichelson
commented
Oct 21, 2016
| @@ -46,27 +46,28 @@ def initialized(self): | |||
|
|
|||
| @staticmethod | |||
| def process_message(store, requester, msg, ready): | |||
| payload = json.loads(msg.data) | |||
There was a problem hiding this comment.
The indirect message data fields are not json, but instead are a list of flag keys (or one flag key in the case of indirect/patch). We were failing here when attempting to parse the json.
example:
event: indirect/patch
data: big.00.bigFeatureKey
drichelson
changed the title
|
👍 |
|
lgtm |
eli-darkly
added a commit
that referenced
this pull request
Jun 12, 2018
re-add missing clear method to user keys cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix indirect streaming messages. I ran the integration harness with these changes (including a big feature flag that triggers an indirect/put) and it passed.