Add Twisted support for LDD mode #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 10, 2016 11:27
# Conflicts: # twisted-requirements.txt
| @@ -10,24 +10,24 @@ def __init__(self): | |||
| self._initialized = False | |||
| self._features = {} | |||
|
|
|||
| def get(self, key): | |||
| def get(self, key, callback): | |||
There was a problem hiding this comment.
Technically this is an interface change that should require us to change the version to 3.0..
There was a problem hiding this comment.
Does this work in the non-twisted world?
There was a problem hiding this comment.
yes- Locally I ran the integration harness against the redis and in-memory feature store
| @@ -66,43 +66,43 @@ def test_initialized(self, store): | |||
| def test_get_existing_feature(self, store): | |||
| store = self.base_initialized_store(store) | |||
| expected = self.make_feature('foo', 10) | |||
| assert store.get('foo') == expected | |||
| assert store.get('foo', lambda x: x) == expected | |||
There was a problem hiding this comment.
It might be clearer to define this identity function once, and reference it in all the places.
|
lgtm |
|
Is there a twisted RESTWrapper in place? |
|
@jkodumal This is only for LDD mode. We don't have LDD running in our restwrapper environment, but the twisted restwrapper passes locally. |
eli-darkly
added a commit
that referenced
this pull request
May 25, 2018
detect uWSGI threads option, not just enable-threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this is recycled from before we removed Twisted support.