Skip to content

Send the toggle default value with flag request events #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2016
Merged

Send the toggle default value with flag request events #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29bffaa
Send the toggle default value with flag request events
jkodumal Feb 2, 2016
f6eebfe
Test that toggle creates an event including the default
jkodumal Feb 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ldclient/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def cb(feature):
if val is None:
val = default
self._send({'kind': 'feature', 'key': key,
'user': user, 'value': val})
'user': user, 'value': val, 'default': default})
return val

if self._config.stream and self._store.initialized:
Expand Down
2 changes: 1 addition & 1 deletion testing/test_ldclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_toggle_event():
client.toggle('feature.key', user, default=None)

def expected_event(e):
return e['kind'] == 'feature' and e['key'] == 'feature.key' and e['user'] == user and e['value'] == True
return e['kind'] == 'feature' and e['key'] == 'feature.key' and e['user'] == user and e['value'] == True and e['default'] == None

assert expected_event(client._queue.get(False))

Expand Down